Migrate messageCreate off sapphire #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBacabac
commented
Aug 18, 2022
| import { ApplyOptions } from '@sapphire/decorators'; | ||
| import { container, Listener } from '@sapphire/framework'; | ||
| import { Message } from 'discord.js'; | ||
| import { ILogger } from '@sapphire/framework'; |
There was a problem hiding this comment.
Keep sapphire dependency for logger
| @@ -61,7 +59,7 @@ const punishSpammersAndTrolls = async (message: Message): Promise<boolean> => { | |||
| error: (err as Error).toString() | |||
| }); | |||
| } | |||
| await sendKickEmbed(message, user, reason, isSuccessful); | |||
| await sendKickEmbed(client, message, user, reason, isSuccessful); | |||
There was a problem hiding this comment.
Pass in the client as argument rather than using container
| if (message.author.bot && message.author.id !== IRC_USER_ID) { | ||
| return; | ||
| } | ||
| export const initMessageCreate = async (client: Client, logger: ILogger, message: Message): Promise<void> => { |
There was a problem hiding this comment.
Convert class to function
| @@ -9,8 +8,13 @@ export const EMBED_COLOUR = '#0099ff'; | |||
| /* | |||
| * Send kick embed | |||
| */ | |||
| export const sendKickEmbed = async (message: Message, user: User, reason = '', isSuccessful = true): Promise<void> => { | |||
| const { client } = container; | |||
There was a problem hiding this comment.
Use client argument instead of container
Picowchew
requested changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Migrates messageCreate logic to a discord.js based file in src/events.
PRs
Resolves #315
Steps to Reproduce
Behaviour is confirmed to be the same with no regressions.